@sgiehl opened this Pull Request on April 30th 2020 Member

fixes #13471

Note: matomo-php-tracker already only sends cip param when token_auth is provided. See https://github.com/matomo-org/matomo-php-tracker/blob/ed2de26b2a5710292d09436a246998d1e28b5760/MatomoTracker.php#L1737,L1739

@tsteur commented on April 30th 2020 Member

@sgiehl are there other things in the tracker that need to be checked? Eg cdt? But I suppose some CDT is valid vs some other isn't so it is tricky

@sgiehl commented on May 5th 2020 Member

@tsteur haven't checked all parameters. but cdt isn't easy. We would need to check the config for tracking_requests_require_authentication_when_custom_timestamp_newer_than and compare it with the value to say if a token auth is required or not.

@tsteur commented on May 5th 2020 Member

Thought it wouldn't be easy. All good shouldn't be needed I suppose

@sgiehl commented on May 6th 2020 Member

Fixed the failing test. @tsteur is that good to merge then?

This Pull Request was closed on May 6th 2020
Powered by GitHub Issue Mirror