@diosmosis opened this Pull Request on April 28th 2020 Member

Fixes #15870

@tsteur commented on April 28th 2020 Member

looks good if tests pass @diosmosis I haven't done a full test but debugged and looks good. It was applying the correct TTL and basically the lock instance now persists the time across individual archives as the instance is created when the archives starts and added to the stack.

It seems when browser archiving is enabled, it may not 100% work though. In my case it was creating the lock eg every time for each metric
image

I reckon this impacts only browser archiving though (haven't tested cron archiving). Maybe you could quickly double check it only creates the lock once per cron archive?

@tsteur commented on April 28th 2020 Member

Actually, I think it might have been because I had archiving forced (always_archive_data_day=1) so all good

@diosmosis commented on April 28th 2020 Member

@tsteur I can confirm it doesn't get called in core:archive for me, but for it to get called, the archiving job would have to run for a long time (even if I set the timeout to 30s, it would have to run for more than my local jobs run for).

@tsteur commented on April 28th 2020 Member

@diosmosis sorry seems one test is now failing: https://travis-ci.org/github/matomo-org/matomo/jobs/680785282#L923

Not sure if the value is expected? Feel free to merge once the test is fixed.

This Pull Request was closed on April 29th 2020
Powered by GitHub Issue Mirror