We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There was #15749 and #15747
But I think it might not fully work actually. In performance insights still seeing these queries executed quote often and taking quite some resources. It seems like might be because in getDb() https://github.com/matomo-org/matomo/blob/3.13.5-rc1/core/DataAccess/LogAggregator.php#L1188 we always create a new instance of ArchivingDbAdapter and therefore https://github.com/matomo-org/matomo/blob/3.13.5-rc1/core/DataAccess/ArchivingDbAdapter.php#L37 would be quite often null.
getDb()
null
BTW should maybe change the default value to 0 so it's not null + $timeBetweenReexpires in reexpireLock().
0
null + $timeBetweenReexpires
reexpireLock()
Maybe would somehow need to remember the last time per archiving lock?
fyi @diosmosis
The text was updated successfully, but these errors were encountered:
@tsteur fyi created a PR
Sorry, something went wrong.
Fixed by #15874
diosmosis
No branches or pull requests
There was #15749 and #15747
But I think it might not fully work actually. In performance insights still seeing these queries executed quote often and taking quite some resources. It seems like might be because in
getDb()
https://github.com/matomo-org/matomo/blob/3.13.5-rc1/core/DataAccess/LogAggregator.php#L1188 we always create a new instance of ArchivingDbAdapter and therefore https://github.com/matomo-org/matomo/blob/3.13.5-rc1/core/DataAccess/ArchivingDbAdapter.php#L37 would be quite oftennull
.BTW should maybe change the default value to
0
so it's notnull + $timeBetweenReexpires
inreexpireLock()
.Maybe would somehow need to remember the last time per archiving lock?
fyi @diosmosis
The text was updated successfully, but these errors were encountered: