Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When ping is enabled, do not extend the visit in other requests #15861

Closed
tsteur opened this issue Apr 25, 2020 · 3 comments
Closed

When ping is enabled, do not extend the visit in other requests #15861

tsteur opened this issue Apr 25, 2020 · 3 comments
Labels
invalid For issues or pull requests that are no longer relevant to Matomo core.

Comments

@tsteur
Copy link
Member

tsteur commented Apr 25, 2020

When ping is enabled, add a flag eg ping_enabled=1 to all other tracking requests. In that case we'd know a ping request will follow to update log_visit.visit_last_action_time and time on site. Therefore, it is not needed to update these fields avoiding potential locks on log_visit, less IO, ...
@tsteur tsteur added the c: Performance For when we could improve the performance / speed of Matomo. label Apr 25, 2020
@tsteur
Copy link
Member Author

tsteur commented Apr 26, 2020

Especially interesting once ping is enabled by default in #8225

@toredash
Copy link
Contributor

Is this a change in behavior for visits that is coming in 4.0 ? I discussed this in #15179 where I expected last_action_time to be updated when using heartbeats.

I'm wondering since I have a plugin that updates a visits visit_last_action_time with the timestamp present in the heartbeat.

@tsteur tsteur added invalid For issues or pull requests that are no longer relevant to Matomo core. and removed c: Performance For when we could improve the performance / speed of Matomo. labels Apr 27, 2020
@tsteur
Copy link
Member Author

tsteur commented Apr 27, 2020

Good point. Heartbeat is actually indeed not supposed to extend the visit by default and therefore will close the issue. Wasn't remembering that at the moment. It could be done if there was an option that it extends the visit but if it's not the default it wouldn't help too many.

@tsteur tsteur closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid For issues or pull requests that are no longer relevant to Matomo core.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsteur @toredash