Reactivates some skipped tests #15848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Tests & QA
Let's create an issue for this if it happens and schedule it. We wouldn't do this during any of the Matomo 4 work and rather skip it again otherwise as the priority is currently Matomo 4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tests are currently skipped on mysqli because of random failures. As that occurred back on PHP 5 on trusty distribution I think it's time to give them another try.
The test ran more than 5 times now on travis and didn't fail. So guess should be fine. But let's have an eye on that and if any of those tests should fail randomly again, we maybe should investigate them instead of skipping them again.