Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to use Dependency Injection #15847

Closed
mikkeschiren opened this issue Apr 22, 2020 · 3 comments
Closed

Document how to use Dependency Injection #15847

mikkeschiren opened this issue Apr 22, 2020 · 3 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Milestone

Comments

@mikkeschiren
Copy link
Contributor

The class StaticContainer has been marked as deprecated a long time ("It will be removed in 3.0") - and it is still used extensively in the core code - should it still be marked as deprecated when it is in fact in use?

@sgiehl
Copy link
Member

sgiehl commented Apr 22, 2020

refs #8567

@tsteur tsteur added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Apr 22, 2020
@tsteur tsteur modified the milestones: 4.0.0, 4.0.0 RC Apr 22, 2020
@tsteur
Copy link
Member

tsteur commented Apr 22, 2020

We can indeed remove this deprecation. Should be a quick one. We should make clear that we discourage the usage though and recommend to use proper __constructor injection where possible. Eg in the doc header for that method.

@tsteur
Copy link
Member

tsteur commented Jun 28, 2020

The class still exists but we no longer support it as official API. We've documented eg in https://developer.matomo.org/guides/dependency-injection how to use dependency injection instead

@tsteur tsteur closed this as completed Jun 28, 2020
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 28, 2020
@mattab mattab changed the title Question: StaticContainer deprecated or not? Question: StaticContainer deprecated or not? Document how to use Dependency Injection Sep 28, 2020
@mattab mattab changed the title Question: StaticContainer deprecated or not? Document how to use Dependency Injection Document how to use Dependency Injection (StaticContainer deprecated or not?) Sep 28, 2020
@mattab mattab removed the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 28, 2020
@mattab mattab changed the title Document how to use Dependency Injection (StaticContainer deprecated or not?) Document how to use Dependency Injection Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Development

No branches or pull requests

4 participants