Run UI tests of submodules with core build if possible #15844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
diosmosis
reviewed
Apr 26, 2020
| // if the plugin is a .git checkout, it's not part of core | ||
| var gitDir = path.join(pathToPlugin, '.git'); | ||
| // skip plugins that have special needs in core build | ||
| var gitDir = path.join(pathToPlugin, 'tests/travis'); |
There was a problem hiding this comment.
The variable & function name could be changed to be more accurate
There was a problem hiding this comment.
Also, I think this method is for running the tests locally so modifying it might affect test running locally w/ git checkouts of pro plugins, eg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Some plugins have special needs in travis setup. Those might not be runable with core build, as they might fail. This currently affects LoginLdap & TagManager
fixes #9253