Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moves Annotations.getDateRangeForPeriod to plugin class #15840

Merged
merged 1 commit into from Apr 22, 2020
Merged

moves Annotations.getDateRangeForPeriod to plugin class #15840

merged 1 commit into from Apr 22, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 21, 2020

refs #6535

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 21, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Apr 21, 2020
@diosmosis
Copy link
Member

some tests are failing, looks like there are some missing uses

@sgiehl
Copy link
Member Author

sgiehl commented Apr 22, 2020

@diosmosis should be fixed now

@diosmosis diosmosis merged commit d3e8c02 into 4.x-dev Apr 22, 2020
@diosmosis diosmosis deleted the annotationsapi branch April 22, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis