Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes VisitsSummary.getColumns #15838

Merged
merged 1 commit into from Apr 21, 2020
Merged

removes VisitsSummary.getColumns #15838

merged 1 commit into from Apr 21, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 21, 2020

refs #6535

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 21, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Apr 21, 2020
sgiehl
sgiehl commented Apr 21, 2020
View reviewed changes
plugins/VisitFrequency/API.php
@@ -120,7 +120,7 @@ protected function unprefixColumns(array $requestedColumns, $suffix)
protected function prefixColumns($table, $period, $suffix)
{
$rename = array();
foreach (APIVisitsSummary::getInstance()->getColumns($period) as $oldColumn) {
foreach ($table->getColumns() as $oldColumn) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply renaming all columns should have the same effect, but makes the getColumns method obsolete

@diosmosis diosmosis merged commit 7c7c061 into 4.x-dev Apr 21, 2020
@diosmosis diosmosis deleted the visitsummaryapi branch April 21, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis