Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors the way segments are configured in dimensions #15836

Merged
merged 4 commits into from Apr 23, 2020
Merged

Refactors the way segments are configured in dimensions #15836

merged 4 commits into from Apr 23, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 21, 2020

fixes #11783

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 21, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Apr 21, 2020
@sgiehl sgiehl force-pushed the refactoring branch 4 times, most recently from 8bd76a6 to ba950d8 Compare April 21, 2020 12:16
@sgiehl sgiehl removed the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 21, 2020
diosmosis
diosmosis approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgiehl
Copy link
Member Author

sgiehl commented Apr 22, 2020

@tsteur do you want to have a look if the changes matches your expectations?

@tsteur
Copy link
Member

tsteur commented Apr 23, 2020

Looks good 👍

This was referenced Apr 23, 2020
Merged
Merged
Merged
@sgiehl sgiehl merged commit a8d9177 into 4.x-dev Apr 23, 2020
@sgiehl sgiehl deleted the refactoring branch April 23, 2020 07:43
@mattab mattab changed the title Refactores the way segments are configured in dimensions Refactors the way segments are configured in dimensions Sep 29, 2020
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Piwik 4 refactoring notes
4 participants
@sgiehl @tsteur @diosmosis @mattab