When segment browser archiving is disabled, assume all segments are supposed to be preprocessed #15834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upposed to be preprocessed
diosmosis
approved these changes
Apr 21, 2020
|
Realising this would also use regular done flags for certain archives that are processed "dependent" where this shouldn't be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if someone disables browser segment archiving, and had previously set some segments to be archived in browser, that these segments will then be correctly preprocessed during archiving without needing to change the
auto_archiveflag in the segment DB table (or through the UI).It also prevents random archive done flags to be created like
done90a5a511e1974bcb37613b6daec137ba.MultiChannelConversionAttribution