Always purge today & yesterday and add update for 3.13.5 #15832
Conversation
…ask and add update to add all tables to purge for next version.
diosmosis
added
not-in-changelog
|
Do I understand it correctly that the update script does something similar to this? sudo -u www-data php7.3 console core:purge-old-archive-data allBecause that took over 10 minutes with my small DB and fast SSD, which means the update will time out for nearly all Matomo users (unless they do it from the cli, which nearly no one does). |
|
@Findus23 The update adds the dates to the list that is used during scheduled task execution. So the next scheduled task run will run the equivalent of that command (though I think the table optimization is in it's own task). |
|
@diosmosis I reckon it be enough to add this in the update script only for the months since march 2020 since that's when it was an issue? |
|
@tsteur 👍 will make that change |
|
@tsteur updated |
core/Updates/3.13.5-rc1.php
Outdated
| list($year, $month) = explode('_', $date); | ||
|
|
||
| $dateObj = Date::factory("$year-$month-01 00:00:00"); | ||
| if ($dateObj->isEarlier($startOfProblem)) { // only add if the table is for march 2020 or above since that is when the problem appeared |
There was a problem hiding this comment.
I haven't checked it yet... but this would only run it for march if it was executed eg on April 23rd 2020 right? Although I suppose that's fine since we'd add today anyway on every purge and April would be deleted that way 👍
There was a problem hiding this comment.
I'm not sure what you mean, but it will run it if it finds an archive table for march or later. Though actually, this won't work because we also have to add the year table. I'll just add it if the year is 2020 or greater.
There was a problem hiding this comment.
I meant "2020-04-01 00:00:00" would be earlier than 2020-04-23 and therefore it wouldn't do it for April but it's not important since it would do it automatically anyway when the task is executed next
There was a problem hiding this comment.
The dates used should always be -01 00:00:00 in this code, i'm not sure why the execution date of the update matters.
…15832) * Always purge today/yesterday when running invalidated archive purge task and add update to add all tables to purge for next version. * Add some comments. * Only add dates if they are past 2020-03. * Only add tables above 2020-01.
…15832) * Always purge today/yesterday when running invalidated archive purge task and add update to add all tables to purge for next version. * Add some comments. * Only add dates if they are past 2020-03. * Only add tables above 2020-01.
Fix #15822