add a more helpful info to the default matomo.php output #15828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Findus23
added
c: Usability
tsteur
reviewed
Apr 19, 2020
| @@ -79,7 +79,8 @@ public function outputResponse(Tracker $tracker) | |||
| Common::sendResponseCode(400); | |||
| } | |||
| Common::printDebug("Empty request => Matomo page"); | |||
| echo "This resource is part of Matomo. Keep full control of your data with the leading free and open source <a href='https://matomo.org' target='_blank' rel='noopener noreferrer nofollow'>web analytics & conversion optimisation platform</a>."; | |||
| echo "This resource is part of Matomo. Keep full control of your data with the leading free and open source <a href='https://matomo.org' target='_blank' rel='noopener noreferrer nofollow'>web analytics & conversion optimisation platform</a>.<br>\n"; | |||
| echo "This file is the endpoint for the Matomo tracking API. If you want to access the Matomo UI or use the Reporting API, please use <a href='index.php'>index.php</a> instead."; | |||
There was a problem hiding this comment.
@Findus23 I suppose noreferrer nofollow might not be needed in this case since it goes to the same install and there is a noindex?
There was a problem hiding this comment.
Sorry, missed the first mail. (need to write a mail filter that marks mentions separately)
I don't think they are needed as they just link to the Matomo main page which would most likely redirect to the login (for random visitors) which is not indexed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As two people contacted me in a few days because they seem to have mixed up matomo.php and index.php, I propose to add a more direct help to the default output.