Add test to ensure there are no plugin updates for core plugins #15815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
reviewed
Apr 15, 2020
tsteur
commented
Apr 15, 2020
| $numTestedCorePlugins = 0; | ||
|
|
||
| // eg these plugins are managed in a submodule and they are installing all tables/columns as part of their plugin install method etc. | ||
| $corePluginsThatAreIndependent = array('TagManager'); |
There was a problem hiding this comment.
we can add later more plugins when/if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11221
see #11221 (comment) and below.
Basically things are working except if someone was to manually remove a plugin from
PluginInstalled. We basically don't want to define plugin updates for core plugins anyway and rather want to ensure to have them incore/Updates.This test worked for me. I was basically copying a test into Goals plugin and then the test failed