Make sure to set cookie name before loading any cookie #15814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
commented
Apr 15, 2020
| @@ -3102,7 +3102,7 @@ if (typeof window.Piwik !== 'object') { | |||
| var cookieName = getCookieName('cvar'), | |||
| cookie = getCookie(cookieName); | |||
|
|
|||
| if (cookie.length) { | |||
| if (cookie && cookie.length) { | |||
There was a problem hiding this comment.
cookie might be 0 so better to check if it is set
sgiehl
approved these changes
Apr 15, 2020
|
build js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14978
As described in the issue we need to make sure that
setCookieNamePrefixis executed beforesetSiteId.Because the method is now executed early, we now longer really need to get the custom variables from cookie there because the method is executed so early that it will be loaded correctly later as part of
loadCustomVariables. Nonetheless loading them if it was attempted to load them earlier eg when there is a manually created tracker instance that isn't using_paq.pushbuttracker.setCookieNamePrefix()