Fix fatal error when trying to install Matomo when PHP version is too low #15813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15771
To reproduce issue you can change
$piwik_minimumPHPVersion = '7.2.0';to eg$piwik_minimumPHPVersion = '7.5.0';and temporarily remove yourconfig/config.ini.php. You will then see it shows a fatal error because the auto loader has not been loaded yet.With this patch it shows correct error message
Not needed for 3.X since most users would have PHP 5.5+ anyway.
Also removed the sentence mentioning PHP4 and PHP 5.3 linking to https://matomo.org/faq/how-to-install/faq_77/ as it's outdated and the solution in https://matomo.org/faq/how-to-install/faq_77/ likely doesn't even work that often and is quite complicated so not too helpful.