added hook allowing to replace idSite in Live plugin API #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple idSites in query
|
The hook could also apply to "getCounters" for the Real time counter to work, I'll add it there. Cheers! |
mattab
pushed a commit
that referenced
this pull request
Nov 27, 2013
added hook allowing to replace idSite in Live plugin API
mattab
added a commit
that referenced
this pull request
Nov 27, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds possibility to alter idSite parameter in Live plugin API so that other plugins can replace single idSite with imploded string of other idSites. It could be that it's not the only place that should be changed to fully introduce this functionality for Live plugin, so in that case just please let me know where else should this be added and I'll update pull request.