Fix piwik js minified tests #15797
Closed
Fix piwik js minified tests #15797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think after merging #15784 (comment) the JS tests are broken. In the PR the tests were green but that's because we merged another piwikjs PR that was created afterwards that it is broken now
tsteur
added
not-in-changelog
|
build js |
|
@tsteur guess you forgot to add something maybe? you actually only added a whitespace? Also the Javascript tests are running 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think after merging #15784 (comment) the JS tests are broken. In the PR the tests were green but that's because we merged another piwikjs PR that was created afterwards that it is broken now