Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume plugins that do not define a upper bound for Matomo version re… #15796

Merged
merged 3 commits into from Apr 16, 2020
Merged

Assume plugins that do not define a upper bound for Matomo version re… #15796

merged 3 commits into from Apr 16, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 8, 2020

…quirement as incompatible with Matomo 4

fixes #14342

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 8, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Apr 8, 2020
@diosmosis
Copy link
Member

Should we make a note in the CHANGELOG? And should we note this in the developer documentation?

I wonder if it would be helpful (and even possible) to have an error message displaying the reason for the automatic < 4.0.0-b1? I think some developers may get confused, but I'm not too sure (cc @tsteur).

@sgiehl
Copy link
Member Author

sgiehl commented Apr 14, 2020

Actually I guess we will need to update the marketplace and the developer docs. It seems we currently allow anything semver can parse. See https://developer.matomo.org/guides/distributing-your-plugin
ping @tsteur

@tsteur
Copy link
Member

tsteur commented Apr 14, 2020

@sgiehl I've updated the marketplace for new plugin submissions or updates for existing plugins to require a lower and an upper limit. A developer will get an email with the error message and it will automatically suggest a good require string for that plugin when possible. Could you update the docs on developer site to have upper limits?

@sgiehl sgiehl force-pushed the versioncheck branch 2 times, most recently from f85e9cb to df12761 Compare April 15, 2020 09:43
@sgiehl
Copy link
Member Author

sgiehl commented Apr 15, 2020

Updated the PR and adjusted the tests. Would be ready for another review

@sgiehl sgiehl mentioned this pull request Apr 15, 2020
Merged
diosmosis
diosmosis approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess the only thing left is the developer docs tweak?

@tsteur
Copy link
Member

tsteur commented Apr 15, 2020

Merged the docs 👍

@sgiehl sgiehl merged commit e943702 into 4.x-dev Apr 16, 2020
@sgiehl sgiehl deleted the versioncheck branch April 16, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Restrict open-ended require to the major Matomo version it defined
3 participants
@sgiehl @diosmosis @tsteur