@sgiehl opened this Pull Request on April 8th 2020 Member

…quirement as incompatible with Matomo 4

fixes #14342

@diosmosis commented on April 8th 2020 Member

Should we make a note in the CHANGELOG? And should we note this in the developer documentation?

I wonder if it would be helpful (and even possible) to have an error message displaying the reason for the automatic < 4.0.0-b1? I think some developers may get confused, but I'm not too sure (cc @tsteur).

@sgiehl commented on April 14th 2020 Member

Actually I guess we will need to update the marketplace and the developer docs. It seems we currently allow anything semver can parse. See https://developer.matomo.org/guides/distributing-your-plugin
ping @tsteur

@tsteur commented on April 14th 2020 Member

@sgiehl I've updated the marketplace for new plugin submissions or updates for existing plugins to require a lower and an upper limit. A developer will get an email with the error message and it will automatically suggest a good require string for that plugin when possible. Could you update the docs on developer site to have upper limits?

@sgiehl commented on April 15th 2020 Member

Updated the PR and adjusted the tests. Would be ready for another review

@tsteur commented on April 15th 2020 Member

Merged the docs 👍

This Pull Request was closed on April 16th 2020
Powered by GitHub Issue Mirror