Faster segmented suggested values when browser archiving is disabled #15786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
the
Pull Request WIP
tsteur
added
Needs Review
sgiehl
reviewed
Apr 8, 2020
| public function setSuggestedValuesApi($suggestedValuesApi) | ||
| { | ||
| if (!empty($suggestedValuesApi) && is_string($suggestedValuesApi)) { | ||
| if (Development::isEnabled() && strpos($suggestedValuesApi, '.get') === false) { |
There was a problem hiding this comment.
Guess we can ignore that this might throw a warning in development mode if setSuggestedValuesApi is called with something else than a string
plugins/API/API.php
Outdated
| } | ||
| } | ||
|
|
||
| $flat = strpos($segment['suggestedValuesApi'], 'Actions.') === 0; |
There was a problem hiding this comment.
Wondering if there would be a better solution than hardcoding that for Actions only. Maybe we could always flatten the report if the API method has subtables with the same dimension or something like that 🤔
There was a problem hiding this comment.
I had it hard coded flattened initially, but then noticed there was an issue with the content dimensions for example where it then would return content name - content piece instead of just content name. technically, I suppose we could check the metadata and see if there is a subtableApiMethod defined and whether it is the same API method or a different one. Should there be a different api method we could disable flattening. Was hoping though to not needing to do it simply to keep things simple. I suppose it wouldn't be that complex though maybe. Will check later.
sgiehl
reviewed
Apr 9, 2020
plugins/API/API.php
Outdated
| @@ -624,8 +626,6 @@ public function getSuggestedValuesForSegment($segmentName, $idSite) | |||
| ); | |||
| if (!empty($segment) && preg_match('/^' . implode('|',$remove) . '/', $segment)) { | |||
| $values[] = urldecode(urldecode(str_replace($remove, '', $segment))); | |||
| } else { | |||
| $values[] = $row->getColumn('label'); | |||
There was a problem hiding this comment.
removing that actually requires a segment metadata to be set, right? should we maybe mention that in the doc block of setSuggestedValuesApi
diosmosis
added a commit
that referenced
this pull request
Apr 16, 2020
* Avoid possible error subtable already exists but not loaded (#15779) * Make sure to always set JSON_PIWIK to native JSON when possible (#15785) * make sure to always set JSON_PIWIK to native JSON when possible * rebuilt piwik.js * Force POST for bulk requests, fix alwaysUseSendBeacon not respected for bulk requests (#15784) * Force POST for bulk requests, fix alwaysUseSendBeacon not respected for bulk requests * rebuilt piwik.js * Make sure to clean up tracking failures before sending email notification (#15798) Feedback from a customer... Eg the daily `cleanupTrackingFailures()` action might be only executed after the weekly `notifyTrackingFailures` therefore we should try to clean up failures first and then check if any are left. Avoids the case where a user opens hours later the email they receive and then there are no tracking failures reported. This could still happen but it's a bit less likely. * 3.13.5-b1 * Faster segmented suggested values when browser archiving is disabled (#15786) * Faster segmented suggested values when browser archiving is disabled * make sure no segment is set * remove wrong var type * fix/add tests * add more segment values * detect if we should flatten or not * add docs * Fix problem when comparing segments or opening popovers (#15809) refs #15805 * purge all old archives regardless of done value (#15800) * purge all old archives regardless of done value, we only care about the newest usable one * Fix test and start on new one. * Add coverage for change in tests. * there is no longer an inner join so should not need the idsite check * Add more parameters to the computeNbUnique event (#15808) * 3.13.5-b2 * One click update in two parts so new code is loaded for second. (#15770) * One click update in two parts so new code is loaded for second. * remove no longer needed code Co-authored-by: Thomas Steur <tsteur@users.noreply.github.com> Co-authored-by: Matthieu Aubry <mattab@users.noreply.github.com> Co-authored-by: Stefan Giehl <stefan@matomo.org>
mattab
added
the
not-in-changelog
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
…atomo-org#15786) * Faster segmented suggested values when browser archiving is disabled * make sure no segment is set * remove wrong var type * fix/add tests * add more segment values * detect if we should flatten or not * add docs
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
…atomo-org#15786) * Faster segmented suggested values when browser archiving is disabled * make sure no segment is set * remove wrong var type * fix/add tests * add more segment values * detect if we should flatten or not * add docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15732
Also fixes an issue where the wrong segment metadata was created for Page URL/Title not defined and eg segmented visitor log did not work for these.