Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie domain config is not applied in ignore cookie preventing opt out to work #15778

Closed
tsteur opened this issue Apr 5, 2020 · 7 comments
Closed
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Privacy For issues that impact or improve the privacy. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Apr 5, 2020

matomo-org/tracker-proxy#58

We need to set similar to the third party cookie https://github.com/matomo-org/matomo/blob/3.13.4/core/Tracker/Request.php#L707-L710 also set the cookie domain here: https://github.com/matomo-org/matomo/blob/3.13.4/core/Tracker/IgnoreCookie.php#L61

@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. c: Privacy For issues that impact or improve the privacy. labels Apr 5, 2020
@tsteur tsteur added this to the 4.1.0 milestone Apr 5, 2020
@yrammos
Copy link

yrammos commented Jun 25, 2020

@tsteur Is there any chance this could be triaged to an earlier release? It is an absolutely crippling bug on low-traffic installations because analytics are severely distorted by maintainers' visits. Thank you for your consideration.

tsteur added a commit that referenced this issue Jun 26, 2020
fix #15778 

tracker cookie name and path was already set, but not the cookie domain.
@tsteur
Copy link
Member Author

tsteur commented Jun 26, 2020

@yrammos if you are familiar with applying patches or changes to a file then you could try to apply this and give it a test: https://github.com/matomo-org/matomo/pull/16123/files

It might only be merged with Matomo 4.1 though maybe (or earlier).

@yrammos
Copy link

yrammos commented Jun 26, 2020

@tsteur thank you for responding so briskly. I applied your patch and it appears to be a partial improvement. Before the patch, the ignore cookie was ineffective on all my websites. With the patch, Matomo ignores only visits to websites hosted on Matomo's domain. More specifically:

matomo.domain.com => Matomo installation
✔️domain.com => Successfully ignored after the patch
X otherdomain.com => Ignore cookie still not working

@tsteur
Copy link
Member Author

tsteur commented Jun 28, 2020

I see... this might actually not going to work then with the tracker proxy... unless you were always using the same domain for all proxies.

It may needs a different fix eg in tracker proxy itself or so.

@yrammos
Copy link

yrammos commented Jun 29, 2020

@tsteur I now noticed that the issue is not limited to the tracker proxy. I can reproduce it exactly as described in my previous post using the JS tracker, as well. Is my case an isolated one?

@tsteur
Copy link
Member Author

tsteur commented Jun 29, 2020

@yrammos yes this could also be a general issue if you want to have cookies set on a specific domain.

FYI we'll merge the cookie domain change as part of this PR probably today #13301

This will be in Matomo 4.

@tsteur
Copy link
Member Author

tsteur commented Jul 3, 2020

This particular issue was actually fixed @yrammos

matomo-org/tracker-proxy#58 is still open as you mention it's not fully fixed yet which is because the tracker proxy seems to be needing a fix too to handle this correctly.

@tsteur tsteur closed this as completed Jul 3, 2020
@mattab mattab modified the milestones: 4.1.0, 4.0.0 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Privacy For issues that impact or improve the privacy. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants