Notifications with the same id might not be shown at all #15773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Bug
|
yes. should be on 3.x-dev as well. |
|
@sgiehl agreed with @diosmosis, be great to apply to 3.x-dev as well 👍 |
|
Not sure how often that actually happens in 3.x-dev haven't seen any reports etc unless I'm mistaken so might not need to make that effort for 3.x-dev and rather focus on 4.x |
|
@tsteur for sure there was no issue yet, as it's hard to know that a notification isn't shown where it should be. That affects for example the "unprocessed segment" notification, that is shown when a segment has been changed, but wasn't reprocessed by the cron archiver yet. Which might also happen on cloud I guess. Isn't hard to move that to 3.x-dev branch. Can do that tomorrow... |
sgiehl
force-pushed
the
notificationclose
branch
from
c1133aa
to
640fba8
Compare
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to fix the tests for #15736 I wondered why the
UnprocessedSegmentTestdidn't show the notification anymore. Reproducing that locally showed that, due to the additional report on the tested page, the notification is contained two times. When loading the page directly (not by clicking the menu), the reports seems to be rendered on the same time, causing both notifications to remove each other.Not sure if the applied fix is the best option, but wasn't sure how to prevent the removal in another way...