Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

triple equals #15762

Merged
merged 4 commits into from May 12, 2020
Merged

triple equals #15762

merged 4 commits into from May 12, 2020

Conversation

tolbon
Copy link
Contributor

@tolbon tolbon commented Mar 31, 2020

Maybe a too big commit but just add an other equals for strict type checking

I modify core/Updater/Migration/Db/DropColumn.php with delete unnecessary code cause placeColumnAfter never exist in this scope

@tolbon
Copy link
Contributor Author

tolbon commented Mar 31, 2020 •
edited

I modify == to === in 2 cases
if(count($var) == fix_number)
or
if($va == fix_string)

@tsteur
Copy link
Member

tsteur commented May 12, 2020

Thanks @tolbon just fixed some merge conflicts and looks good to merge once tests pass 👍

@tsteur tsteur merged commit c870770 into matomo-org:4.x-dev May 12, 2020
@mattab mattab added this to the 4.0.0 milestone Sep 10, 2020
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

@Findus23 Findus23 Findus23 left review comments

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tolbon @tsteur @sgiehl @Findus23 @mattab