In all other cases that method
Rules::shouldProcessReportsAllPlugins is called with the idSite we are currently archiving vs in these cases it was potentially called with children idSites (when roll up reporting is used with a specific setting).
Rules::isSegmentPreProcessed() -> Rules::getSegmentsToProcess()
Rules::isSegmentPreProcessed(1,2)but then it thinks the segment for idSite 3 is not prearchived.
I've done some extensive testing and it seems this change alone fixes the issue and no change in roll up reporting is needed. I can only assume the reason this was never noticed is:
Question: There is another call to
getArchiveGroupOfPlugin, does this one need to be changed as well or not?
No, it uses a totally different parameter class