Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds INI setting to disable referrer spam blocklist #15744

Merged
merged 6 commits into from Apr 8, 2020
Merged

Adds INI setting to disable referrer spam blocklist #15744

merged 6 commits into from Apr 8, 2020

Conversation

john357smith
Copy link
Contributor

Added option to disable referrer spam blacklist.

@john357smith
Update VisitExcluded.php
8a9c9ba 
Added option to disable referrer spam blacklist.
@john357smith
Update VisitExcluded.php
1e5a1bc 
Config parameter changed to enable_spam_filter.
@tsteur tsteur mentioned this pull request Mar 29, 2020
Closed
@john357smith
Update global.ini.php
c0b2db2 
Added option to disable spam blacklist.
@john357smith
Copy link
Contributor Author

global..ini.php updated in this branch,. previous PR closed.

@tsteur tsteur added this to the 4.0.0 milestone Mar 30, 2020
@tsteur tsteur added the Needs Review PRs that need a code review label Mar 30, 2020
@sgiehl sgiehl changed the title Update VisitExcluded.php Adds option to disable referrer spam blacklist Mar 31, 2020
sgiehl
sgiehl requested changes Mar 31, 2020
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions for code improvements. Additionally it would make sense to also add that config check to the task that updates the spam list, as it's actually not needed when the list is not used at all. See

matomo/plugins/CoreAdminHome/Tasks.php

Lines 84 to 86 in 22cde64

if(SettingsPiwik::isInternetEnabled() === true){
$this->weekly('updateSpammerBlacklist');
}

core/Tracker/VisitExcluded.php Outdated Show resolved Hide resolved
core/Tracker/VisitExcluded.php Outdated Show resolved Hide resolved
core/Tracker/VisitExcluded.php Outdated Show resolved Hide resolved
john357smith and others added 2 commits March 31, 2020 22:21
@john357smith @sgiehl
Update core/Tracker/VisitExcluded.php
6fcdff3 
Co-Authored-By: Stefan Giehl <stefan@matomo.org>
@john357smith @sgiehl
Update core/Tracker/VisitExcluded.php
972ec04 
Co-Authored-By: Stefan Giehl <stefan@matomo.org>
@sgiehl
Copy link
Member

sgiehl commented Apr 6, 2020

@john357smith are you able to add the config check also in the file I've mentioned in my previous comment, so the spamlist is not update automatically if not needed:

matomo/plugins/CoreAdminHome/Tasks.php

Lines 84 to 86 in 22cde64

if(SettingsPiwik::isInternetEnabled() === true){
$this->weekly('updateSpammerBlacklist');
}

@john357smith
Update Tasks.php
5b0fda8 
Added check if spam filter is enabled.
@john357smith
Copy link
Contributor Author

@john357smith are you able to add the config check also in the file I've mentioned in my previous comment, so the spamlist is not update automatically if not needed:

matomo/plugins/CoreAdminHome/Tasks.php

Lines 84 to 86 in 22cde64

if(SettingsPiwik::isInternetEnabled() === true){
$this->weekly('updateSpammerBlacklist');
}

File updated.

@john357smith john357smith requested a review from sgiehl April 7, 2020 18:58
@sgiehl sgiehl merged commit bb4cad6 into matomo-org:4.x-dev Apr 8, 2020
@sgiehl
Copy link
Member

sgiehl commented Apr 8, 2020

@john357smith Thanks for updating and your contribution. Will be included in Matomo 4 👍

@sgiehl sgiehl mentioned this pull request Apr 8, 2020
Closed
@sgiehl sgiehl linked an issue Apr 8, 2020 that may be closed by this pull request
Disable spamlist in configuration #15743
Closed
@john357smith john357smith deleted the patch-1 branch April 11, 2020 08:52
@mattab mattab changed the title Adds option to disable referrer spam blacklist Adds INI setting to disable referrer spam blocklist Sep 28, 2020
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Disable spamlist in configuration
4 participants
@john357smith @sgiehl @tsteur @mattab