Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for tracker plugins no longer worked #15737

Merged
merged 1 commit into from Apr 1, 2020
Merged

Fix tests for tracker plugins no longer worked #15737

merged 1 commit into from Apr 1, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 26, 2020

Regression from #15568

When running JS tests like https://foo.bar/tests/javascript/ then the tracker.js of tracking plugins was no longer included in the matomo.js

@tsteur
Fix tests for tracker plugins no longer worked
3de7364 
Regression from #15568

When running JS tests like https://foo.bar/tests/javascript/ then the tracker.js of tracking plugins was no longer included in the matomo.js
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 26, 2020
@tsteur tsteur added this to the 3.13.5 milestone Mar 26, 2020
@diosmosis
Copy link
Member

should this change be visible in tests?

@tsteur
Copy link
Member Author

tsteur commented Apr 1, 2020

@diosmosis nope. Only in premium feature JS tests.

@diosmosis diosmosis merged commit 8c9c318 into 3.x-dev Apr 1, 2020
@diosmosis diosmosis deleted the r15568 branch April 1, 2020 23:28
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@tsteur @jonasgrilleres
Fix tests for tracker plugins no longer worked (matomo-org#15737)
1a4fff8 
Regression from matomo-org#15568

When running JS tests like https://foo.bar/tests/javascript/ then the tracker.js of tracking plugins was no longer included in the matomo.js
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@tsteur @jbuget
Fix tests for tracker plugins no longer worked (matomo-org#15737)
bc3928e 
Regression from matomo-org#15568

When running JS tests like https://foo.bar/tests/javascript/ then the tracker.js of tracking plugins was no longer included in the matomo.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.13.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis