Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codespell report for "Matomo" (on fossies.org) #15729

Closed
jschleus opened this issue Mar 24, 2020 · 2 comments · Fixed by #15730
Closed

Codespell report for "Matomo" (on fossies.org) #15729

jschleus opened this issue Mar 24, 2020 · 2 comments · Fixed by #15730
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@jschleus
Copy link

The FOSS server fossies.org - also supporting "Matomo" - offers a feature "Source code misspelling reports". Such reports are normally only generated on request, but as Fossies administrator I have just created for testing purposes such a codespell based analysis for the new Matomo release 3.13.4:

  https://fossies.org/linux/www/matomo-3.13.4.tar.gz/codespell.html

Although after a first review some obviously wrong matches ("False Positives" = FPs) are already filtered out (ignored) please inform me if you find more of them so that I can force a new improved check if applicable.

Just for information there are also two supplemental pages showing some used "codespell" configuration details and all obvious False Positives.

If appropriate, additional reports for the current release or also master versions (these in a special "test" folder) could be willingly created.

OT: As Fossies admin I am somewhat annoyed that a single file ("How to install Matomo.html") is located outside of the main subdirectory "matomo", as Linux user that the filename contains spaces and as a general user that the file seems superfluous since already existing within the directory "matomo/misc".

@jschleus
Copy link
Author

jschleus commented Apr 8, 2020

Since I saw the great efforts regarding spelling corrections I just added the "matomo" GitHub branches "master", "3.x-dev" and "4.x-dev" to a special Fossies folder named "/linux/test" that isn't integrated into the Fossies services and should also not be accessible for search engines.

The sources are at least currently cloned half-hourly and the according Fossies codespell reports are visible under

https://fossies.org/linux/test/matomo-3.x-dev-snap.tar.gz/codespell.html
(currently -> https://fossies.org/linux/test/matomo-3.x-dev.fdb685c.200408.tar.gz/codespell.html)

https://fossies.org/linux/test/matomo-4.x-dev-snap.tar.gz/codespell.html
(currently -> https://fossies.org/linux/test/matomo-4.x-dev.2c5c72e.200408.tar.gz/codespell.html)

https://fossies.org/linux/test/matomo-master.tar.gz/codespell.html
(currently -> https://fossies.org/linux/test/matomo-master.62121d3.200325.tar.gz/codespell.html)

And with a little bit of luck (since it's a new and not yet well tested feature) one can see future changes regarding code spellings under the new "history" button that links for e.g. to

https://fossies.org/linux/test/matomo-4.x-dev-snap.tar.gz/codespell_hist.html

Maybe this can be a little bit helpful as a supplement (although the correction of spelling errors has probably a low priority).

@mattab
Copy link
Member

mattab commented Apr 28, 2020

Hello @jschleus
Thanks for this 👍
Btw, when you create any PR or issues, would you be able to add the label not-in-changelog?
This would save us some time and hide the PRs/issues from our changelog generator tool. Thanks!

EDIT: you can ignore my comment, just realised it was us creating the PRs :-)

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants