Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic login after one click update #15725

Closed
sgiehl opened this issue Mar 24, 2020 · 2 comments · Fixed by #15755
Closed

Fix automatic login after one click update #15725

sgiehl opened this issue Mar 24, 2020 · 2 comments · Fixed by #15755
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.0.0

Comments

@sgiehl
Copy link
Member

sgiehl commented Mar 24, 2020

Our UI tests for automatic login after a one click update currently fails on 4.x-dev
That might be a regression and should be fixed.
@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Mar 24, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Mar 24, 2020
@sgiehl
Copy link
Member Author

sgiehl commented Apr 8, 2020

guess that will be fixed with #15770

@diosmosis
Copy link
Member

Actually should be fixed by #15755, I think it's due to the app specific token auth change, the user's token auth is no longer valid so a login is required. Not sure if it will happen after 4.x is released...

@sgiehl sgiehl linked a pull request Apr 14, 2020 that will close this issue
try to fix two UI tests #15755
Merged
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

try to fix two UI tests matomo-org/matomo
3 participants
@diosmosis @mattab @sgiehl