Add possibility to silently stop the archiver without an error #15724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
the
Enhancement
mattab
added
Task
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
tsteur
added a commit
that referenced
this pull request
Sep 28, 2020
Was added in #15724 but somehow got lost if 4.x
tsteur
added a commit
that referenced
this pull request
Sep 28, 2020
Was added in #15724 but somehow got lost if 4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needing this for cloud. We're listening there to
CronArchive.init.startevent and under circumstances we may trigger an exception there to not archive any data.The problem is, that this exception is passed on to the
consolecommand and then it returns exit code != 0 meaning we receive an email from crontab every time this happens.Could have appended another parameter to the postEvent to specifically abort archiving in this event but wasn't sure if that could cause any issue breaking things in 3.X and using the exception you can technically abort the archiving at any time which may be helpful. Won't be an official feature though.
Tested this and worked nicely. We will be using this on Cloud already with 3.13.4 in a patch.