Improve sorting of action details #15723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of sorting the actions differed between PDO and MYSQLI database adapters.
That's the reason why various tests were failing in the AllTests build.
The reason is quite simple, but was hard to find...
PDO returns integer values as integers while MYSQLI returns them as strings. The sorting by action
type
then results in different results as the value might be a string or an integer. Comparing those can have different results...