Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on bionic distribution & run AllTests with PHP 7.4 #15720

Merged
merged 22 commits into from Apr 19, 2020
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 23, 2020

Note: I've also done various tests with distributions trusty and xenial. Builds for both will work as well. But trusty doesn't support PHP 7.4

Also see matomo-org/travis-scripts#56

refs #15617

@sgiehl sgiehl added the Needs Review PRs that need a code review label Mar 23, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Mar 23, 2020
@sgiehl sgiehl added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Mar 23, 2020
diosmosis
diosmosis previously approved these changes Mar 25, 2020
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure if this requires other plugin PRs to be merged first or anything?

@sgiehl
Copy link
Member Author

sgiehl commented Mar 26, 2020

Merging the travis scripts will need some updates on several travis.yml files. Will do that next week

@sgiehl
Copy link
Member Author

sgiehl commented Apr 7, 2020

I've updated some more parts of the code and all tests seem to run on PHP 7.4 now.
Unfortunately it seems the version of imagemagick preinstalled on bionic distribution has problems with comparing the very big images. Those compares currently result in a

the 'compare' command output could not be parsed, should be an integer, got: compare: 
../../magick/quantum.c:216: DestroyQuantumInfo: Assertion `quantum_info != (QuantumInfo *) NULL' failed.

Seems the policies set for imagemagick differs. While the limitations for image size or memory usage are commented out on trusty builds, they are limited on bionic builds. Maybe that causes that error. Will have a closer look at that tomorrow.

@tsteur
Copy link
Member

tsteur commented Apr 7, 2020

Is this a travis issue maybe? Could create a bug report there and wait for a month or two to see if something happens? Running tests on PHP 7.4 might not be highest priority so it could wait?

I suppose we can't use the old distro for UI tests and run it on older PHP versions easily?

@sgiehl sgiehl force-pushed the php74tests branch 3 times, most recently from 1b9086c to a1ac05f Compare April 8, 2020 08:03
@sgiehl
Copy link
Member Author

sgiehl commented Apr 8, 2020

tried using an own policy for imagemagick, but that doesn't work either. Will check if we can use xenial for the UI build and if the error is the same there...

@sgiehl sgiehl force-pushed the php74tests branch 2 times, most recently from ed536f0 to 39c63e6 Compare April 17, 2020 12:05
@sgiehl sgiehl merged commit 7e6b13c into 4.x-dev Apr 19, 2020
@sgiehl sgiehl deleted the php74tests branch April 19, 2020 13:52
@sgiehl sgiehl modified the milestones: 4.0.0 RC, 4.0.0 Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants