New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on bionic distribution & run AllTests with PHP 7.4 #15720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure if this requires other plugin PRs to be merged first or anything?
Merging the travis scripts will need some updates on several travis.yml files. Will do that next week |
d465b95
to
64a20a8
Compare
792cda0
to
18849b0
Compare
445a493
to
18849b0
Compare
I've updated some more parts of the code and all tests seem to run on PHP 7.4 now.
Seems the policies set for imagemagick differs. While the limitations for image size or memory usage are commented out on trusty builds, they are limited on bionic builds. Maybe that causes that error. Will have a closer look at that tomorrow. |
Is this a travis issue maybe? Could create a bug report there and wait for a month or two to see if something happens? Running tests on PHP 7.4 might not be highest priority so it could wait? I suppose we can't use the old distro for UI tests and run it on older PHP versions easily? |
1b9086c
to
a1ac05f
Compare
tried using an own policy for imagemagick, but that doesn't work either. Will check if we can use xenial for the UI build and if the error is the same there... |
ed536f0
to
39c63e6
Compare
Note: I've also done various tests with distributions
trusty
andxenial
. Builds for both will work as well. Buttrusty
doesn't support PHP 7.4Also see matomo-org/travis-scripts#56
refs #15617