Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segments to exclude a URL are still shown in the visits log. #15708

Closed
jmumby opened this issue Mar 18, 2020 · 4 comments
Closed

Segments to exclude a URL are still shown in the visits log. #15708

jmumby opened this issue Mar 18, 2020 · 4 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@jmumby
Copy link

jmumby commented Mar 18, 2020

When creating a segment to exclude a particular string. Results are still shown in the visits log.

image

@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Mar 19, 2020
@tsteur
Copy link
Member

tsteur commented Mar 19, 2020

I suppose technically the user visited a page that did not include that string, and therefore this result be actually expected from what is currently implemented.

@tsteur tsteur added this to the Backlog (Help wanted) milestone Mar 19, 2020
@mattab
Copy link
Member

mattab commented Mar 19, 2020

@tsteur a few people have reported this and finding it not clear/not what they expect.

If we wanted to change the implementation of "Does not contain" for actions, would that be possible and how much effort would it be?

@tsteur
Copy link
Member

tsteur commented Mar 19, 2020

@mattab I don't know if it's possible. Would estimate a few days since it requires rewriting a lot of deep core logic in join tables generator, segment query generator, etc and ensuring nothing breaks etc. Also if it works, it would potentially mean performance implications to already slow action queries (especially when it comes to contains). Is this a duplicate of #13785 ?

@mattab
Copy link
Member

mattab commented Mar 19, 2020

Marking as duplicate of #13785

@mattab mattab closed this as completed Mar 19, 2020
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

3 participants