Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid update problem if token_auth table does not yet exist #15706

Merged
merged 2 commits into from Mar 19, 2020
Merged

Avoid update problem if token_auth table does not yet exist #15706

merged 2 commits into from Mar 19, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 18, 2020

Regression from #15410

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Mar 18, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Mar 18, 2020
tsteur
tsteur reviewed Mar 18, 2020
View reviewed changes
core/FrontController.php Outdated Show resolved Hide resolved
@sgiehl
Copy link
Member Author

sgiehl commented Mar 18, 2020

@tsteur I've moved and improved the code a bit. Could you have another look

@tsteur
Copy link
Member

tsteur commented Mar 19, 2020

Left a comment. Otherwise should work 👍

@sgiehl sgiehl merged commit da8fda7 into 4.x-dev Mar 19, 2020
@sgiehl sgiehl deleted the fixupdate branch March 19, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis left review comments

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @tsteur @diosmosis