Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Process unique visitor metric for Roll-ups (set enable_processing_unique_visitors_multiple_sites = 1)" #15701

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 17, 2020

Reverts #15450

The previous PR will only work when enable_fingerprinting_across_websites is also enabled. This is a privacy issue though. As a result archiving will break with roll up reporting etc. I reckon this PR should therefore be reverted as it broke RollUpReporting and fixing that would cause privacy issues.

…sing_unique_visitors_multiple_sites = 1) (#15450)"

This reverts commit 65b1fcd.
@tsteur tsteur added the Needs Review PRs that need a code review label Mar 17, 2020
@tsteur tsteur added this to the 4.0.0 milestone Mar 17, 2020
@diosmosis
Copy link
Member

Would it also help to emit some kind of error when config has mismatched values?

@tsteur
Copy link
Member Author

tsteur commented Mar 17, 2020

It does during archiving should a roll up be configured.

@diosmosis diosmosis merged commit 47376fb into 4.x-dev Mar 18, 2020
@diosmosis diosmosis deleted the revert-15450-enable_processing_unique_visitors_multiple_sites branch March 18, 2020 19:45
@diosmosis
Copy link
Member

FYI @mattab, merged this

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants