Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure stringify/parse is a function #15688

Merged
merged 2 commits into from Mar 24, 2020
Merged

Ensure stringify/parse is a function #15688

merged 2 commits into from Mar 24, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 11, 2020

Avoid this error:

Uncaught TypeError: JSON_PIWIK.stringify is not a function at ds (VM60 matomo.js:52) at cs (VM60 matomo.js:52) at bZ (VM60 matomo.js:54) at VM60 matomo.js:69 at cg (VM60 matomo.js:59) at Q.trackPageView (VM60 matomo.js:69) at Object.af [as push] (VM60 matomo.js:23) at :3:12 at e.realInitialNavigatedEvent (matomo-application-.js:1) at e.navigatedEvent (matomo-application-.js:1)

@tsteur tsteur added the Needs Review PRs that need a code review label Mar 11, 2020
@tsteur tsteur added this to the 3.13.5 milestone Mar 11, 2020
@tsteur
Copy link
Member Author

tsteur commented Mar 11, 2020

build js

@tsteur tsteur merged commit 95ab54e into 3.x-dev Mar 24, 2020
@tsteur tsteur deleted the ensurestringify branch March 24, 2020 21:23
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@tsteur @jonasgrilleres
Ensure stringify/parse is a function (matomo-org#15688)
822dd37
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@tsteur @jbuget
Ensure stringify/parse is a function (matomo-org#15688)
76871de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.13.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl