Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #15681 secure cookie flag is not set for referrer and custom dimensions #15683

Merged
merged 2 commits into from Mar 9, 2020
Merged

fix #15681 secure cookie flag is not set for referrer and custom dimensions #15683

merged 2 commits into from Mar 9, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 7, 2020

Suppose the minified version should now be generated automatically through github action.

fix #15681

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 7, 2020
@tsteur tsteur added this to the 4.0.0 milestone Mar 7, 2020
@sgiehl
Copy link
Member

sgiehl commented Mar 7, 2020 •
edited

@tsteur it's not fully automated yet. You need to post a comment with the content "build js" in it, to trigger a build:

@diosmosis diosmosis merged commit 0ca7356 into 4.x-dev Mar 9, 2020
@diosmosis diosmosis deleted the t15681 branch March 9, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Check that all Matomo cookies are set with the secure flag
3 participants
@tsteur @sgiehl @diosmosis