Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove director detection #15677

Closed
wants to merge 3 commits into from
Closed

Remove director detection #15677

wants to merge 3 commits into from

Conversation

pebosi
Copy link
Contributor

@pebosi pebosi commented Mar 6, 2020

Discussion on #15627 was to decide to remove detection of some plugin detections.

@tsteur
Copy link
Member

tsteur commented Mar 20, 2020

fyi @pebosi same here as in the Gears we would also use a 0 in the fingerprint where director used to be used.

@mattab mattab added this to the 4.0.0 milestone May 8, 2020
@tsteur
Copy link
Member

tsteur commented May 12, 2020

Hi @pebosi are you still working on this?

@pebosi
Copy link
Contributor Author

pebosi commented May 12, 2020

Will look into this, later this week

@sgiehl
Copy link
Member

sgiehl commented May 26, 2020

Will finish that in a new PR as well...

@sgiehl sgiehl closed this May 26, 2020
@sgiehl sgiehl mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pebosi @tsteur @sgiehl @mattab