Make sure to set secure flag when setting samesite none #15676
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
sgiehl
approved these changes
Mar 6, 2020
|
|
|
It would still work maybe if they use 3rd party cookies on same domains I suppose. |
|
👍 I guess it doesn't hurt to have it then. We may have to document the requirement to put matomo on https for some people then... Actually we shouldn't encourage using http. But that's not related to this issue, really. |
|
We're recommending this here btw: https://matomo.org/blog/2020/02/new-cookie-behaviour-in-browsers-may-cause-regressions/ |
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #15672
this PR will also need to be merged to fix #15672 matomo-org/tag-manager#229
@MichaelHeerklotz can you maybe also have a look at this PR
Not sure how to fallback when HTTPS is not used. Should we still set to None and assume it works for a while in some browsers that are not Chrome but eventually it'll fail? I suppose it's not quite a solution. I assume
Laxmaybe won't work so well for 3rd party tracking?