Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to update nonce in out out frame when using new window #15671

Merged
merged 4 commits into from Mar 6, 2020
Merged

try to update nonce in out out frame when using new window #15671

merged 4 commits into from Mar 6, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 5, 2020

fixes #15629

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 5, 2020
@sgiehl sgiehl added this to the 3.13.4 milestone Mar 5, 2020
@sgiehl sgiehl linked an issue Mar 5, 2020 that may be closed by this pull request
Using Opt-Out iFrame twice doesn't work #15629
Closed
@diosmosis
Copy link
Member

Maybe we could add this test to the optoutform UI test? I think we could simply add a page reload after one test to check the setting is retained (the should correctly show the checkbox unchecked after reloading after opting-out test).

@diosmosis
Copy link
Member

diosmosis commented Mar 5, 2020 •
edited

Tested on chrome, firefox & safari. Works for me. Should probably test on IE.

The browserstack email sign-in seems broken for me...

@sgiehl sgiehl force-pushed the optouttwice branch 5 times, most recently from a4b1c37 to 72f9d75 Compare March 5, 2020 16:15
@sgiehl
Copy link
Member Author

sgiehl commented Mar 5, 2020

@diosmosis added another UI test

@diosmosis diosmosis merged commit 8f7befe into 3.x-dev Mar 6, 2020
@diosmosis diosmosis deleted the optouttwice branch March 6, 2020 11:24
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@sgiehl @jonasgrilleres
try to update nonce in out out frame when using new window (matomo-or…
bebcf95 
…g#15671)

* allow some pixels difference for usermanager tests

* try to update nonce in out out frame when using new window

* Ensure https warning is hidden in optout ui test

* adds UI test
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@sgiehl @jbuget
try to update nonce in out out frame when using new window (matomo-or…
e8c7a48 
…g#15671)

* allow some pixels difference for usermanager tests

* try to update nonce in out out frame when using new window

* Ensure https warning is hidden in optout ui test

* adds UI test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.13.4
Development

Successfully merging this pull request may close these issues.

Using Opt-Out iFrame twice doesn't work
2 participants
@sgiehl @diosmosis