Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid formatting ecommerce conversion rate twice #15668

Merged
merged 1 commit into from Mar 5, 2020
Merged

Avoid formatting ecommerce conversion rate twice #15668

merged 1 commit into from Mar 5, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 5, 2020

fixes #15637

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 5, 2020
@sgiehl sgiehl added this to the 3.13.4 milestone Mar 5, 2020
@sgiehl sgiehl linked an issue Mar 5, 2020 that may be closed by this pull request
Ecommerce Orders Conversion Rate Rounding Error #15637
Closed
@diosmosis diosmosis merged commit 10c8d80 into 3.x-dev Mar 5, 2020
@diosmosis diosmosis deleted the ecommerceformat branch March 5, 2020 12:57
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@diosmosis @jonasgrilleres
Avoid formatting ecommerce conversion rate twice (matomo-org#15668)
b54a339
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@diosmosis @jbuget
Avoid formatting ecommerce conversion rate twice (matomo-org#15668)
5225041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.13.4
Development

Successfully merging this pull request may close these issues.

Ecommerce Orders Conversion Rate Rounding Error
2 participants
@sgiehl @diosmosis