Try to prevent a deadlock when writing options #15666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
diosmosis
reviewed
Mar 5, 2020
| @@ -78,11 +78,12 @@ public function getAllRememberToInvalidateArchivedReportsLater() | |||
| // we do not really have to get the value first. we could simply always try to call set() and it would update or | |||
| // insert the record if needed but we do not want to lock the table (especially since there are still some | |||
| // MyISAM installations) | |||
| $values = Option::getLike($this->rememberArchivedReportIdStart . '%'); | |||
| $values = Option::getLike('%' . $this->rememberArchivedReportIdStart . '%'); | |||
There was a problem hiding this comment.
Sometimes I see '%_' . and other times '%' ., could that be an issue?
There was a problem hiding this comment.
@diosmosis not really. I just copied behaviour what was done on the right part, to have the same on the left. It'll not make a difference though
|
I don't see a change to the |
|
@diosmosis yes there should! Will add it now. I used to have it there but must have been undone by some other reverts |
|
@diosmosis actually it works because it is already partially sent with the |
|
looks good to merge if tests pass 👍 |
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #15545 (comment)
Invalidator tests passed for me locally. Not sure I missed something maybe?