@tsteur opened this Pull Request on March 5th 2020 Member

refs https://github.com/matomo-org/matomo/issues/15545#issuecomment-594927218

Invalidator tests passed for me locally. Not sure I missed something maybe?

@diosmosis commented on March 5th 2020 Member

I don't see a change to the Option::getLike() in deleteOptionLike(), should there be one?

@tsteur commented on March 5th 2020 Member

@diosmosis yes there should! Will add it now. I used to have it there but must have been undone by some other reverts

@tsteur commented on March 5th 2020 Member

@diosmosis actually it works because it is already partially sent with the % when the method is called. I will make that more clear. It's confusing right now

@diosmosis commented on March 5th 2020 Member

looks good to merge if tests pass 👍

This Pull Request was closed on March 5th 2020
Powered by GitHub Issue Mirror