Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix void return used and "improve" isLeap in Date #15662

Merged
merged 2 commits into from Mar 4, 2020
Merged

Fix void return used and "improve" isLeap in Date #15662

merged 2 commits into from Mar 4, 2020

Conversation

tolbon
Copy link
Contributor

@tolbon tolbon commented Mar 4, 2020

let PHP decide if year isLeap or not
Fix strange code with used a return of void function

@sgiehl sgiehl added this to the 4.0.0 milestone Mar 4, 2020
@sgiehl sgiehl added the Needs Review PRs that need a code review label Mar 4, 2020
@sgiehl sgiehl merged commit ff22963 into matomo-org:4.x-dev Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants