@sgiehl opened this Pull Request on March 3rd 2020 Member

fixes #15609

@diosmosis commented on March 5th 2020 Member

Code looks good to me but I'm not too familiar with the related code, so I think @tsteur may want to take a look as well

@tsteur commented on March 5th 2020 Member

Looks good. Left one comment. Haven't tested it though. Be good to make sure some error message will be shown in the UI if the query fails because of a timeout similar to Visitor Log. I suppose that's what happens automatically anyway. Just need to see how it behaves when it's used in transitions eg through a row action

@sgiehl commented on March 6th 2020 Member

@tsteur it show the exception in the overlay if loading a transition through a row action:

image

@tsteur commented on March 8th 2020 Member

@sgiehl I just tested it and it doesn't work. That's because the ranking query will be applied and therefore it's not after the first select.
Not sure how it works for you? Cause they all have ranking query set?

This is my setting

live_query_max_execution_time = 0.001

@tsteur commented on March 9th 2020 Member

btw we could in worst case move this out of 3.13.4 into 3.13.5 if we wanted to release 3.13.4 earlier

@sgiehl commented on March 15th 2020 Member

@tsteur updated the code so it works with the ranking query correctly.

This Pull Request was closed on March 15th 2020
Powered by GitHub Issue Mirror