Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warning from passing 2 args to ucwords() on older PHP versions #15650

Merged
merged 1 commit into from Mar 5, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 2, 2020

fixes #14694

…14734)

* Don't use ucwords on older versions of PHP

* Add comment
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 2, 2020
@sgiehl sgiehl added this to the 3.13.4 milestone Mar 2, 2020
@sgiehl sgiehl linked an issue Mar 2, 2020 that may be closed by this pull request
@sgiehl sgiehl requested a review from diosmosis March 4, 2020 12:56
@diosmosis diosmosis merged commit 0fd0b30 into 3.x-dev Mar 5, 2020
@diosmosis diosmosis deleted the fixucwords branch March 5, 2020 00:36
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
…atomo-org#14734) (matomo-org#15650)

* Don't use ucwords on older versions of PHP

* Add comment

Co-authored-by: Kate Butler <kate@innocraft.com>
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
…atomo-org#14734) (matomo-org#15650)

* Don't use ucwords on older versions of PHP

* Add comment

Co-authored-by: Kate Butler <kate@innocraft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning - ucwords() expects exactly 1 parameter, 2 given
2 participants