@tolbon opened this Pull Request on March 2nd 2020 Contributor

Convert certain Tabs to Spaces,
Fix PHP Docs
Type declaration in function
Fix potential php errors

@tolbon commented on March 3rd 2020 Contributor

I see lot of failing compilation introduce by my modification I fix this asap

@tolbon commented on March 3rd 2020 Contributor

I need help a test don't pass but I don't see where I need to revert

I didn't find where this xml is generated

Edit : It seems good but row goal is before row action and expected is action before goal
I don't know why :-/

@sgiehl commented on March 3rd 2020 Member

you can ignore the both tests mentioned. They are failing on 4.x-dev as well. Guess that's a sorting issue between PHP 7.2 and PHP 7.3 or something like that.

@tolbon commented on March 3rd 2020 Contributor

I know it’s too late but ...
My commit is very big, Very hard for you to reviews this no ? Can I do something
Do you want I close this PR and do more little PR ?

@sgiehl commented on March 4th 2020 Member

Having smaller PRs makes it a lot easier to review and check why tests are failing. This PR has still a lot failing tests, but it's hard to say which change made them fail. So might be better to split the changes

@tolbon commented on March 4th 2020 Contributor

Yeah I close this and make little Pull Request, sorry for this

This Pull Request was closed on March 4th 2020
Powered by GitHub Issue Mirror