Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no popup graph shown after the first in page titles report #15644

Closed
paolobenve opened this issue Feb 29, 2020 · 24 comments
Closed

no popup graph shown after the first in page titles report #15644

paolobenve opened this issue Feb 29, 2020 · 24 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@paolobenve
Copy link

3.13.3

Reproduce it this way:

  • go to Behaviour -> page titles
  • place cursor on a line, and generate the "open row evolution" popup graph
  • close it

Now you cannot generate any more popup graph.

Apparently the bug happens only in the page titles report, similar reports haven't this issue

@paolobenve paolobenve changed the title no popup graph shown after the first no popup graph shown after the first in page titles report Feb 29, 2020
@tsteur
Copy link
Member

tsteur commented Feb 29, 2020

Thanks for creating this issue @paolobenve . Can you reproduce this on https://demo.matomo.org/ ? With popup graph I assume you mean row evolution?

@tsteur
Copy link
Member

tsteur commented Feb 29, 2020

And was this working for you in an earlier version?

@paolobenve
Copy link
Author

Can you reproduce this on https://demo.matomo.org/ ?

no, no on that site, which runs 3.13.2

With popup graph I assume you mean row evolution?

yes

And was this working for you in an earlier version?

I don't know

@tsteur
Copy link
Member

tsteur commented Mar 1, 2020

Just updated it to 3.13.3 @paolobenve . Can you check again maybe? That would be great since I'm not sure how to reproduce it. Seems to work so far.

@paolobenve
Copy link
Author

no, not reproducible... what may be the reason why on my site I have this behaviour?

@tsteur
Copy link
Member

tsteur commented Mar 1, 2020

It's honestly hard to say. Is there any chance for us to get a log in to your Matomo so we can investigate there? if so, could you create a user for us and send the details to hello at matomo.org ?

@paolobenve
Copy link
Author

not reproducible.

I can see that on the demo site, when the popup graph is closed, the hash is restored to the value before opening the popup, while on my site the hash doen't change when I close the popup.

What can I do?

@tsteur
Copy link
Member

tsteur commented Mar 1, 2020

@paolobenve which browser and which browser version are you using?

@paolobenve
Copy link
Author

Chromium 80.0.3987.87 (Build ufficiale) Built on Ubuntu , running on Ubuntu 18.04 (a 64 bit).

Same behaviour in firefox 73.0.1 (64 bit)

@tsteur
Copy link
Member

tsteur commented Mar 2, 2020

@paolobenve this should work in general. If you could create a login for us, so that we can investigate further that would be great?

@paolobenve
Copy link
Author

I created a new no-superuser user, and it doesn't has the bug

Changing its permissions to superuser, it has the bug.

The bug appears when permissions are > view

@paolobenve
Copy link
Author

@tsteur could you reproduce this bug as superuser?

@tsteur
Copy link
Member

tsteur commented Mar 4, 2020

@paolobenve I just tried and couldn't reproduce it unfortunately. If you could create a login for us, that would be great and we would try to reproduce it.

You may even want to first create one other superuser account for yourself and see if you can reproduce it there. Chances are, it might just work. I would then maybe have an idea.

@paolobenve
Copy link
Author

paolobenve commented Mar 5, 2020

https://cathopedia.org/piwik/index.php?module=CoreHome&action=index&idSite=3&period=day&date=yesterday#?idSite=3&period=year&date=2019-03-15&segment=&category=General_Actions&subcategory=Actions_SubmenuPageTitles

@tsteur where do I send you the credentials? I set a user where you have admin access to the analytics of one site

click on "open row evolution" -> the popup is shown and the hash changes
close the popup with the top right x: the hash in the location bar doesn't change (bug)
click again on "open row evolution" -> the popup isn't shown

@tsteur
Copy link
Member

tsteur commented Mar 5, 2020

You can send them to hello at matomo.org @paolobenve

@paolobenve
Copy link
Author

@tsteur sent

@tsteur
Copy link
Member

tsteur commented Mar 5, 2020

@paolobenve I just tried to reproduce this with the login you sent and it works without any issues. Can you try it with that login too?

@chris246
Copy link

chris246 commented Apr 4, 2020

I have a similar issues on the page URLs view on the Dashboard.
I can't voluntarily trigger it, but it occurs more frequently after expanding the sub rows
page 1/
| - page 1.1/
| -- page 1.1.1/

@tsteur
Copy link
Member

tsteur commented Apr 5, 2020

@chris246 same here can you reproduce this on https://demo.matomo.org ?

Can you create a different user in your Matomo and check if it happens with that user as well?

@chris246
Copy link

chris246 commented Apr 9, 2020

No, but on the demo installation I found an other issue:
I can't re-collapse diving any more...

On my local installation, the bug also occurs with a new user.

Furthermore, on my local installation when clicking on "Select a row to compare" ("Wählen Sie eine Zeile zum Vergleichen"), the current dialog sometimes does not close. Closing it manually and selecting an additional row works though.

@sgiehl
Copy link
Member

sgiehl commented Apr 9, 2020

@chris246 does the label of the row selected for row evolution maybe contain a special char? There's a known bug, which is already fixed for Matomo 4.
To check that you could replace this line:

if(param != 'segment') {

with

if(param != 'segment' && param != 'popover') {

Let me know if that fixes your issue and we will consider including the fix in the next 3.x release as well.

@chris246
Copy link

chris246 commented Apr 9, 2020

The page URLs are generated by TYPO3 for this website: https://docs.typo3.org/m/typo3/reference-tca/master/en-us/ColumnsConfig/Type/Slug.html

After changing the line as suggested, I could not yet trigger the bug again.
I'll post a new reply here, if it occurs again.

Regarding the Row comparing: Shall I create a new issue for that?

@Findus23
Copy link
Member

So it seems like this has already been fixed with 10b5a85 and #15805

In case this is not fixed by changing that line (and regenerating the JS), please comment and I'll reopen the issue.

@Findus23 Findus23 added the Bug For errors / faults / flaws / inconsistencies etc. label Apr 20, 2020
@chris246
Copy link

chris246 commented May 4, 2020

Hi,
I observed the bug again twice using 3.13.5 :/

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

6 participants