Replace jscrollpane with native #15636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from origin
tsteur
reviewed
Mar 20, 2020
| @@ -24,8 +24,6 @@ | |||
| "ngDialog": "~1.3.0", | |||
| "mousetrap": "~1.4.0", | |||
| "sprintf": "~1.0.0", | |||
| "jScrollPane": "~2.0.0", | |||
| "jquery-mousewheel": "~3.1.12", | |||
There was a problem hiding this comment.
@pebosi I suppose mousewheel was removed by accident?
There was a problem hiding this comment.
I see this was used in combination with jScrollPane.
|
Worked for me locally as well. I'm restarting the tests and will merge should all be fine. Always great to see when we can remove a big amount of code and use native solutions. Cheers @pebosi |
|
Looks like no tests failed 👍 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrolling the Segments list without old libs. Tested on Firefox / Chrome.