@sgiehl opened this Pull Request on February 28th 2020 Member

fixes #15625

@diosmosis commented on February 29th 2020 Member

Think we can add a unit test for this method? I know there isn't one already and there probably should've be one, thought it would be good to at least test this change imo.

@tsteur commented on February 29th 2020 Member

Something like we have in SessionTest should work

@diosmosis commented on February 29th 2020 Member

@tsteur you mean as an existing test or a place for a new test? I was thinking a simple unit test that tested the output of the method.

@tsteur commented on February 29th 2020 Member

Unit test for output makes sense 👍

@sgiehl commented on March 2nd 2020 Member

added some tests

This Pull Request was closed on March 2nd 2020
Powered by GitHub Issue Mirror