Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix session cookie expire #15633

Merged
merged 2 commits into from Mar 2, 2020
Merged

Fix session cookie expire #15633

merged 2 commits into from Mar 2, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 28, 2020

fixes #15625

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 28, 2020
@sgiehl sgiehl added this to the 3.13.4 milestone Feb 28, 2020
@sgiehl sgiehl linked an issue Feb 28, 2020 that may be closed by this pull request
'Remember me' not working because cookie expire is in wrong format #15625
Closed
@Findus23 Findus23 mentioned this pull request Feb 28, 2020
Closed
@diosmosis
Copy link
Member

Think we can add a unit test for this method? I know there isn't one already and there probably should've be one, thought it would be good to at least test this change imo.

@tsteur
Copy link
Member

tsteur commented Feb 29, 2020

Something like we have in SessionTest should work

@diosmosis
Copy link
Member

@tsteur you mean as an existing test or a place for a new test? I was thinking a simple unit test that tested the output of the method.

@tsteur
Copy link
Member

tsteur commented Feb 29, 2020

Unit test for output makes sense 👍

@sgiehl
Copy link
Member Author

sgiehl commented Mar 2, 2020

added some tests

@diosmosis diosmosis merged commit 9c3c724 into 3.x-dev Mar 2, 2020
@diosmosis diosmosis deleted the sessionexpire branch March 2, 2020 09:45
This was referenced Mar 4, 2020
Closed
Closed
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@sgiehl @jonasgrilleres
Fix session cookie expire (matomo-org#15633)
0e0a981 
* Fix session expire

fixes matomo-org#15625

* adds some tests
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@sgiehl @jbuget
Fix session cookie expire (matomo-org#15633)
2e51d07 
* Fix session expire

fixes matomo-org#15625

* adds some tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.13.4
Development

Successfully merging this pull request may close these issues.

'Remember me' not working because cookie expire is in wrong format
3 participants
@sgiehl @diosmosis @tsteur