Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jquery placeholder #15632

Merged
merged 6 commits into from Feb 29, 2020
Merged

Remove jquery placeholder #15632

merged 6 commits into from Feb 29, 2020

Conversation

pebosi
Copy link
Contributor

@pebosi pebosi commented Feb 28, 2020

All major browsers support the attribute nativly

@sgiehl sgiehl added the Needs Review PRs that need a code review label Feb 28, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Feb 28, 2020
Findus23
Findus23 approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@Findus23 Findus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine as support is already very common (even IE 10 and 11):
https://caniuse.com/#feat=input-placeholder

@sgiehl
Copy link
Member

sgiehl commented Feb 28, 2020

@pebosi could you also remove it from the list in bower.json:

matomo/bower.json

Line 29 in 98fd1f6

"jquery-placeholder": "~2.0.8",

@pebosi
Copy link
Contributor Author

pebosi commented Feb 29, 2020

@pebosi could you also remove it from the list in bower.json:

matomo/bower.json

Line 29 in 98fd1f6

"jquery-placeholder": "~2.0.8",

Done

@sgiehl sgiehl merged commit 00732ef into matomo-org:4.x-dev Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Findus23 Findus23 Findus23 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pebosi @sgiehl @Findus23