New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gears detection #15627
Remove gears detection #15627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are on it: Should we maybe also remove Quicktime, Realplayer and Director (which I think is the shockwave player)? All of those shouldn't work in any modern browser anymore (and as the report notes, detection doesn't work in IE, so there should be nothing left) |
i would create a pull request per Plugin |
code changes look fine so far. Need to find some time to check it out locally and do some testing... |
I suppose should be fine. Not sure though re removing that data. You're basically removing historical data there of users. It may be fine as likely nobody looks at this anymore, but also feels a bit wrong. |
Looking at the failing tests it seems all fingerprints changed due to the changes here. While that is fine for the tests and we can simply update them. I'm wondering if that is something we should adjust actually, as fingerprints for already tracked users might change after an update and they might be detected as new users then 🤔 Maybe we should use a default value Or is changing the fingerprints fine? (ping @mattab @tsteur ) |
Let's at least mention this clearly in the Developer Changelog? (in a section "Database Schema" or so?)
👍 |
Use 0 as default Co-Authored-By: Stefan Giehl <stefan@matomo.org>
I thought not. |
👍 be great to get this merged @sgiehl not sure if something is missing |
I'll recreate this PR with solved merge conflicts and fixed tests |
Removing detection of old Gears plugin, was developed by Google. It was stopped in 2011: https://gearsblog.blogspot.com/2011/03/stopping-gears.html