@pebosi opened this Pull Request on February 26th 2020 Contributor

Removing detection of old Gears plugin, was developed by Google. It was stopped in 2011: https://gearsblog.blogspot.com/2011/03/stopping-gears.html

@Findus23 commented on March 2nd 2020 Member

While we are on it:

Should we maybe also remove Quicktime, Realplayer and Director (which I think is the shockwave player)?

All of those shouldn't work in any modern browser anymore (and as the report notes, detection doesn't work in IE, so there should be nothing left)

@pebosi commented on March 4th 2020 Contributor

While we are on it:

Should we maybe also remove Quicktime, Realplayer and Director (which I think is the shockwave player)?

All of those shouldn't work in any modern browser anymore (and as the report notes, detection doesn't work in IE, so there should be nothing left)

i would create a pull request per Plugin

@sgiehl commented on March 4th 2020 Member

code changes look fine so far. Need to find some time to check it out locally and do some testing...

@mattab commented on March 5th 2020 Member

Should we maybe also remove Quicktime, Realplayer and Director (which I think is the shockwave player)?

Probably a good idea, any thoughts @sgiehl @tsteur ?

@tsteur commented on March 5th 2020 Member

I suppose should be fine. Not sure though re removing that data. You're basically removing historical data there of users. It may be fine as likely nobody looks at this anymore, but also feels a bit wrong.

@sgiehl commented on March 6th 2020 Member

Looking at the failing tests it seems all fingerprints changed due to the changes here. While that is fine for the tests and we can simply update them. I'm wondering if that is something we should adjust actually, as fingerprints for already tracked users might change after an update and they might be detected as new users then 🤔

Maybe we should use a default value 0 for gears in the config hash instead of removing it here:
https://github.com/matomo-org/matomo/pull/15627/files#diff-02edccc593e3badd1e9fd8d278fd1d35L113

Or is changing the fingerprints fine? (ping @mattab @tsteur )

@mattab commented on March 10th 2020 Member

Not sure though re removing that data. You're basically removing historical data there of users. It may be fine as likely nobody looks at this anymore, but also feels a bit wrong.

Let's at least mention this clearly in the Developer Changelog? (in a section "Database Schema" or so?)

Maybe we should use a default value 0 for gears in the config hash instead of removing it here:

:+1:

Powered by GitHub Issue Mirror